Re: [PATCH] phy: ingenic: fix unbalanced regulator disable in exit

From: Manivannan Sadhasivam

Date: Mon Oct 12 2026 - 04:59:54 EST


On Sun, Sep 06, 2026 at 09:30:31PM +0800, Felix Gu wrote:
> exit() and power_off() both disable vcc_supply, so the regulator
> gets disabled twice for every power cycle, causing an unbalanced
> disable WARN.
>
> Drop the regulator_disable() call from the exit callback and leave
> the regulator to the power_on/power_off pair.
>
> Fixes: 31de313dfdcf ("PHY: Ingenic: Add USB PHY driver using generic PHY framework.")
> Signed-off-by: Felix Gu <ustc.gu@xxxxxxxxx>

Reviewed-by: Manivannan Sadhasivam <manivannan.sadhasivam@xxxxxxxxxxxxxxxx>

- Mani

--
மணிவண்ணன் சதாசிவம்