Re: [PATCH] interconnect: qcom: sdm660: Enable keep_alive and sync_state

[Fabricio Akio]

> None should be necessary on 660, except on bus_0 / RPM_CNOC_PERIPH_CLK,
> which is not associated with any interconnect master on this platform
> (so it will actually get disabled through clock cleanup!)

I tested removing the keep_alives on a Moto X4 (SDM630), on the
sdm660-mainline 7.2 tree with this patch:

  keep_alive on    result
  ---------------  ------------------------------------
  none             resets during boot
  all but bimc     resets during boot
  all but mnoc     boots, powers off in the first suspend
  bimc and mnoc    boots, 10/10 suspends
  all five         boots, 2/2 suspends

So on payton those two seem required, and the other three not.

I also checked bus_0: it isn't disabled here, its active-only clock is
CLK_IS_CRITICAL at 19.2 MHz since your commit e1cd74b6dccb ("clk: qcom:
smd-rpm: Set XO rate and CLK_IS_CRITICAL on PCNoC"), and the RPM votes
logged on the device show it held at 19.2 MHz while the CPUs run.

Would a v2 with keep_alive on bimc and mnoc only look right to you?