[PATCH V2 0/9] soundwire: amd: introduce hw_ops dispatch and split driver into revision-specific files

From: Vijendar Mukunda

Date: Tue Oct 13 2026 - 06:13:54 EST


This is v2 of the AMD SoundWire manager driver refactor series. It
incorporates review feedback from v1 and extends the restructuring to
split the monolithic amd_manager.c into two files.

Changes since v1:
- Patch 4 subject updated: "rename hardware backend symbols" (covers
functions, op-table instances, and the register-offset constant)
- Patch 6: removed the forward reference to "subsequent patches" from
the commit message; dropped WARN_ONCE guards from dispatch helpers
- Patch 7: commit message corrected; #include <linux/workqueue.h>
addition dropped (available transitively)
- Patch 8: amd_sdw_hw_init_ops() now uses a static const
struct amd_sdw_hw_ops instead of devm_kzalloc; amd_sdw_hw_init_ops()
moved after amd_sdw_manager_remove() with a forward declaration before
probe to resolve ordering
- Patch 9 (new): splits amd_manager.c into amd_manager_common.c
(shared revision-independent functions, analogous to cadence_master.c)
and renames what remains to amd_acp63_manager.c (ACP6.3/7.x register-
level backend, analogous to intel_auxdevice.c)

Series overview:

Patches 1-3 are preparatory: rename the manager-count macro to carry
the ACP6.3 scope, convert the pdevinfo/sdw_pdata and pdev arrays in
sdw_amd_probe_controller() from fixed-size stack arrays to heap
allocations sized by the ACP revision.

Patch 4 renames revision-specific hardware-access functions, op-table
instances, and the manager register-offset constant to the amd_acp63_*
/ACP63_* prefix.

Patch 5 removes an unused define.

Patches 6-8 introduce and wire up the hw_ops dispatch framework:
patch 6 defines struct amd_sdw_hw_ops and the inline acp_*() dispatch
helpers; patch 7 converts the irq/work handlers to dispatch per
acp_rev to their ACP6.3-family implementations; patch 8 extracts PM
callbacks into hw_ops slots, populates a static const amd_acp63_hw_ops
table, and converts all remaining direct amd_acp63_*() call sites to
use the corresponding acp_*() wrappers.

Patch 9 splits amd_manager.c: shared revision-independent functions
move to amd_manager_common.c and the ACP6.3/7.0/7.1/7.2 register-level
backend is renamed to amd_acp63_manager.c.

Dependencies:

This series applies on top of the AMD SoundWire fix series posted at:
https://lore.kernel.org/alsa-devel/20261013085111.2009061-1-Vijendar.Mukunda@xxxxxxx/T/#t


Vijendar Mukunda (9):
soundwire: amd: rename AMD_SDW_MAX_MANAGER_COUNT macro
soundwire: amd: allocate pdevinfo and sdw_pdata by ACP revision in
probe
soundwire: amd: allocate sdw_amd_ctx pdev array dynamically
soundwire: amd: rename hardware backend symbols to amd_acp63_*()
prefix
soundwire: amd: remove unused AMD_SDW_MAX_FREQ_NUM define
soundwire: amd: introduce struct amd_sdw_hw_ops dispatch framework
soundwire: amd: dispatch irq/work handlers to per-revision functions
soundwire: amd: populate hw_ops and wire all call sites through
acp_*() helpers
soundwire: amd: extract shared functions into amd_manager_common.c

drivers/soundwire/Makefile | 2 +-
.../{amd_manager.c => amd_acp63_manager.c} | 904 ++++--------------
drivers/soundwire/amd_init.c | 49 +-
drivers/soundwire/amd_manager.h | 255 +++--
drivers/soundwire/amd_manager_common.c | 773 +++++++++++++++
include/linux/soundwire/sdw_amd.h | 9 +-
6 files changed, 1183 insertions(+), 809 deletions(-)
rename drivers/soundwire/{amd_manager.c => amd_acp63_manager.c} (50%)
create mode 100644 drivers/soundwire/amd_manager_common.c

--
2.48.1