Re: [PATCH v3] sched/fair: remove dead code on enqueue_task_fair()

[Kayra Cizmeci]

Ah... Just a dead code removal and look what were dealing with.
But killing your own beast must be a good thing, no? Instead
of just doing nothing.

> > The dequeue()->enqueue() also lets place_entity()
> > 'double-account' the entity's (on dequeue() saved) lag, right?
> > After dequeue:       curr == se, on_rq == 0 -> excl from average
> > enqueue_hierarchy(): curr == se, on_rq == 1 -> incl again
> > place_entity():      calculate placement assuming se is excl

> I'm not entirely sure I follow. With the above fix there is still only
> one place_entity(), which is after enqueue_hierarchy() and has
> ENQUEUE_QUEUED on.

> Here enqueue_hierarchy() adds the entity to h_nr_queued, and
> ENQUEUE_QUEUED tells place_entity() exactly this, so it can adjust.

I think Christian doesn't means the entity count, but the lag doble accounting?
On the case of se == curr, and on_rq == 1? Or maybe I'm missing something. Christian?

Thanks

Kayra