Re: [PATCH 0/2] fuse: convert the readdir cache to use folios

[Tal Zussman]

On 10/13/26 2:13 PM, Bernd Schubert wrote:
> On 10/13/26 19:49, Tal Zussman wrote:
>> On 10/13/26 1:38 PM, Bernd Schubert wrote:
>>> On 10/13/26 18:48, Tal Zussman wrote:
>>>> On 9/24/26 7:42 PM, Tal Zussman wrote:
>>>>> Convert the readdir cache lookups in fs/fuse/readdir.c to folios. This
>>>>> removes the last caller of find_get_page_flags() and one of the last
>>>>> callers of find_lock_page().
>>>>>
>>>>> Based on fuse/for-next.
>>>>>
>>>>
>>>> Hi,
>>>>
>>>> Following up on this. It'd be great to get this in as it would allow us
>>>> to remove find_get_page_flags() and find_lock_page() next cycle.
>>>
>>>
>>> fuse has large folios enabled now - the patches need to handle that.
>>> Even if it would not be enabled yet, Joanne had spend quite some effort
>>> to enable large folios, any change that tried to rely on behavior would
>>> have just increased her burden...
>>>
>> Hi Bernd,
>> 
>> As far as I can see, Joanne's patches enable large folios for regular files.
>> Here we operate on directories, which are initialized through fuse_init_dir()
>> and so do not use large folios. In any case, these patches switch to using
>> the relevant folio helpers, which would get us closer to using large folios
>> in the readdir cache if that's eventually desired.
> 
> Hi Tal,
> 
> oops, sorry, I was bailing out when I read it as "this introduces
> another stop gap for large folios". I quickly scanned over it, but don't
> have much time right now - will review tomorrow morning.
> 
> 
> Sorry again,
> Bernd
> 

No problem, thanks!