Re: [PATCH v1 2/2] ASoC: tegra: Support WM8994 by machine driver

[Mark Brown]

On Tue, Oct 13, 2026 at 09:32:26PM +0300, Svyatoslav Ryhel wrote:
> Add Wolfson Microelectronics WM8994 codec support to the Tegra ASoC
> machine driver. The WM8994 codec is found on devices like LG Optimus 2X
> (P990/star) and Samsung Captivate Glide (SGH-i927).

> +// SPDX-License-Identifier: GPL-2.0-only
> +/*
> + * tegra_wm8994.c - Tegra machine ASoC driver for boards using WM8994 codec.

Please make the entire comment a C++ one so things look more
intentional.

> +static const struct snd_kcontrol_new tegra_wm8994_controls[] = {
> +	SOC_DAPM_PIN_SWITCH("Int Spk"),
> +	SOC_DAPM_PIN_SWITCH("Internal Mic 1"),
> +	SOC_DAPM_PIN_SWITCH("Internal Mic 2"),
> +	SOC_DAPM_PIN_SWITCH("Mic Jack"),
> +	SOC_DAPM_PIN_SWITCH("Line Out"),
> +	SOC_DAPM_PIN_SWITCH("FM Radio"),
> +};

There's no Line Out or FM Radio widgets, you should get errors during
probe.

Attachment: signature.asc
Description: PGP signature