Re: [PATCH net-next v12 09/12] dpll: sit9531x: implement output pin state on a DPLL

[Ali Rouhi]

On Tue, 13 Oct 2026, Ivan Vecera wrote:

> > +static int sit9531x_output_hiz_write(struct sit9531x_dev *sitdev, u8 slot,
> > +                                    bool mute)
> > +{
> > +       struct sit9531x_hiz_pair p[SIT9531X_HIZ_PAIRS];
> > +       u8 mask[SIT9531X_HIZ_PAIRS], state[SIT9531X_HIZ_PAIRS];
> > +       int i, rc, undo_rc;
>
> Reverse X-mas here, please.
>
> With both of them...
>
> Reviewed-by: Ivan Vecera <ivecera@xxxxxxxxxx>

Reordered here, and the same ordering applied across the driver
wherever the swap was free. The blocks whose order carries a dependency
are unchanged.

Your Reviewed-by is on this patch in v13.

Thanks,
Ali