RE:(2) [PATCH] xfs: make pNFS LAYOUTCOMMIT stable the way fdatasync does

From: Daejun Park

Date: Tue Oct 13 2026 - 21:41:14 EST


On Tue, Oct 13, 2026 at 02:08:46PM +0200, Christoph Hellwig wrote:
> That feels like a bit of overkill, given that the shared code is
> just two function calls.

OK, no helper then.

> ... but maybe this helper should move to xfs_log.c and renamed to
> something like xfs_log_force_inode?

Makes sense now that it is used outside xfs_file.c. There already is an
xfs_log_force_inode() in xfs_inode.c, which is the !datasync case of
this one, so in v2 I'll move xfs_fsync_flush_log() next to it and make
xfs_log_force_inode() a wrapper around it.