Re: [PATCH] clk: qcom: gcc-eliza: Use retention for PCIe power domains

[Loic Poulain]

On Wed, Oct 14, 2026 at 1:59 PM Abel Vesa <abel.vesa@xxxxxxxxxxxxxxxx> wrote:
>
> On 26-10-12 14:58:43, Jagadeesh Kona wrote:
> >
> >
> > On 10/12/2026 1:29 AM, Abel Vesa wrote:
> > > When resuming from system suspend on Eliza CQS EVK, gcc_pcie_0_gdsc
> > > gets stuck off when powering back on, preventing the system from resuming.
> > >
> > > Use retention for all four PCIe GDSCs, as on SM8550, to preserve their
> > > state across suspend and allow the system to resume.
> > >
> > > Fixes: 3d356ab4a1ec ("clk: qcom: Add support for Global clock controller on Eliza")
> > > Assisted-by: LLM
> > > Signed-off-by: Abel Vesa <abel.vesa@xxxxxxxxxxxxxxxx>
> > > ---
> > >  drivers/clk/qcom/gcc-eliza.c | 8 ++++----
> > >  1 file changed, 4 insertions(+), 4 deletions(-)
> > >
> >
> >
> > Hi Abel,
> >
> > Using PWRSTS_RET_ON keeps the GDSC forever ON after first enable and the GDSC never
> > collapses.
> >
> > For similar issue on Lemans (pcie_0_gdsc gets stuck off when powering back on), picking
> > the below changes from PCIE side helped to power ON the GDSC properly without any issue.
> >
> > https://lore.kernel.org/all/20260728-hotplug_pci-v1-1-d1f38cfb9122@xxxxxxxxxxxxxxxx/
> > https://lore.kernel.org/all/20260729071514.859778-1-manivannan.sadhasivam@xxxxxxxxxxxxxxxx/
> >
> > Can you please try if above changes are helping on Eliza also?
>
> Thanks for the hint. Mani's patch (v2) is already upstream, so just enabling
> CONFIG_HOTPLUG_PCI_PCIE did the trick.
>
> Suspend/resume works fine now on Eliza, so this patch can be ignored then.

So should the retention configuration above be conditional on
CONFIG_HOTPLUG_PCI_PCIE, or should we simply depend on
CONFIG_HOTPLUG_PCI_PCIE?

Regards,
Loic