Re: [PATCH 1/2] staging: rtl8723bs: remove remaining comparisons to true/false

[Zach Schneider]

> Please read:
>     https://lore.kernel.org/r/2026080354-skater-urgent-31b2@gregkh

Sorry, I missed that policy. I was trying to learn how the contribution process works end to end, and leaned on an LLM to get through it. Your point makes sense though: the learning is in doing the work myself. 

Please drop this series (both 1/2 and 2/2), and I'll come back with patches I've done by hand.

thank you,
Zach Schneider

Mobile: 260.435.9767
https://zachschneider.com/
https://linkedin.com/in/zschneider


On Tuesday, October 13th, 2026 at 11:56 PM, Greg Kroah-Hartman <gregkh@xxxxxxxxxxxxxxxxxxx> wrote:

> On Tue, Oct 13, 2026 at 04:41:28PM -0500, Zach Schneider wrote:
> > Checkpatch reports "Using comparison to true/false is error prone"
> > in rtw_wlan_util.c, hal_com.c, hal_intf.c, odm.c and
> > ioctl_cfg80211.c. Replace "x == true" with "x" and "x == false"
> > with "!x".
> >
> > bwmode_updated, bDisableSWChannelPlan and the HAL_DEF_MACID_SLEEP
> > value are u8, and rtw_validate_ssid() returns u8, but they only ever
> > hold true or false. ODM_RAStateCheck() returns bool. This does not
> > change behavior.
> >
> > Assisted-by: LLM
> > Signed-off-by: Zach Schneider <me@xxxxxxxxxxxxxxxxx>
> > ---
> >  drivers/staging/rtl8723bs/core/rtw_wlan_util.c    | 2 +-
> >  drivers/staging/rtl8723bs/hal/hal_com.c           | 2 +-
> >  drivers/staging/rtl8723bs/hal/hal_intf.c          | 4 ++--
> >  drivers/staging/rtl8723bs/hal/odm.c               | 2 +-
> >  drivers/staging/rtl8723bs/os_dep/ioctl_cfg80211.c | 2 +-
> >  5 files changed, 6 insertions(+), 6 deletions(-)
> 
> Please read:
> 	https://lore.kernel.org/r/2026080354-skater-urgent-31b2@gregkh
> 
> thanks,
> 
> greg k-h
>