Re: [PATCH v2 13/13] media: sony-starvis2: Add support for IMX585

[Jai Luthra]

Hi Dave,

Thank you for the series.

Quoting Dave Stevenson (2026-10-13 20:47:12)
> IMX585 is an 8MPix Starvis 2 sensor, so add support for it.
> 
> Signed-off-by: Dave Stevenson <dave.stevenson@xxxxxxxxxxxxxxx>
> ---
>  drivers/media/i2c/sony-starvis2.c | 302 ++++++++++++++++++++++++++++++++++++++
>  1 file changed, 302 insertions(+)
> 
> diff --git a/drivers/media/i2c/sony-starvis2.c b/drivers/media/i2c/sony-starvis2.c
> index 1ce2b86c57ac..c9a3dd4fe529 100644
> --- a/drivers/media/i2c/sony-starvis2.c
> +++ b/drivers/media/i2c/sony-starvis2.c
[...]
> +const struct starvis2_variant imx585_variant_def = {
> +	.name = "imx585",
> +	.id_reg = CCI_REG16_LE(0x5a1d),
> +	.id_mask = 0x3ff,
> +	.id_value = 0x259,
> +	.active_area = {
> +		.top = 0,
> +		.left = 0,
> +		.width = 3857,
> +		.height = 2201,
> +	},

s/.active_area/.native_area

Apologies for the drive-by comment, I just spotted this and thought it
might result in a painful debug session.

I'll do a proper review for the series, hopefully within this week :-)

Thanks,
Jai

> +	.active_area = {
> +		.top = 20,
> +		.left = 0,
> +		.width = 3856,
> +		.height = 2180,
> +	},
> +	.pixel_rate = 594000000,
> +	.pix_per_clk = 8,
> +	.common_regs = imx585_common_regs,
> +	.num_common_regs = ARRAY_SIZE(imx585_common_regs),
> +	.vmax_default = 2250,
> +	.hmax_min_link_freq = imx585_min_hmax_2lane,
> +	.hmax_min_pixel_array = 550,
> +};
> +

[...]