Re: [PATCH v7 06/11] arm64: dts: qcom: ipq5210: Add ICE support to SDHCI

From: Kathiravan Thirumoorthy

Date: Wed Oct 14 2026 - 12:11:47 EST


On 10/14/2026 10:33 AM, Varadarajan Narayanan wrote:
On Tue, Oct 13, 2026 at 04:43:36PM +0200, Konrad Dybcio wrote:
On 10/12/26 9:23 AM, Varadarajan Narayanan wrote:
Describe the SDHCI ICE register region and clock, and enable CQE support
for the IPQ5210 SDHCI controller.

Signed-off-by: Varadarajan Narayanan <varadarajan.narayanan@xxxxxxxxxxxxxxxx>
---
arch/arm64/boot/dts/qcom/ipq5210.dtsi | 15 +++++++++++----
1 file changed, 11 insertions(+), 4 deletions(-)

diff --git a/arch/arm64/boot/dts/qcom/ipq5210.dtsi b/arch/arm64/boot/dts/qcom/ipq5210.dtsi
index d28d68a10958..c14b42c22616 100644
--- a/arch/arm64/boot/dts/qcom/ipq5210.dtsi
+++ b/arch/arm64/boot/dts/qcom/ipq5210.dtsi
@@ -416,9 +416,11 @@ uart1: serial@1a84000 {
sdhc: mmc@7804000 {
compatible = "qcom,ipq5210-sdhci", "qcom,sdhci-msm-v5";
reg = <0x0 0x07804000 0x0 0x1000>,
- <0x0 0x07805000 0x0 0x1000>;
+ <0x0 0x07805000 0x0 0x1000>,
+ <0x0 0x07808000 0x0 0x2000>;
reg-names = "hc",
- "cqhci";
+ "cqhci",
+ "ice";
This should be a separate node, like on other SoCs to allow things
like frequency scaling
Not sure I understand the comment correctly. I checked agatti, sdm630,
sdm670, sm6350, talos DT files and they have added the ICE region similar
to this.

Can you please suggest an example, will follow that.

Kodiak [1], Monaco [2] has a separate ICE node. For the frequency scaling / OPP support, series is still under review [3].

[1] https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git/tree/arch/arm64/boot/dts/qcom/kodiak.dtsi#n1085

[2] https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git/tree/arch/arm64/boot/dts/qcom/monaco.dtsi#n4883

[3] https://lore.kernel.org/linux-arm-msm/as9ksJKk55wYuoOS@xxxxxxxxxxxxxxxxxxxxxxxxxxxx/T/#mf3a36cd811e7933bfa184366aa77b3f335c5a3ad

Konrad, I hope you are referring the same.


Thanks
Varada