Re: [PATCH] scsi: target: iscsi: Use crypto library API
From: Eric Biggers
Date: Wed Oct 14 2026 - 12:49:24 EST
On Wed, Sep 30, 2026 at 09:48:57PM -0700, Eric Biggers wrote:
> Make iscsi_target_auth.c call into the crypto library directly instead
> of going through crypto_shash. This is simpler and much more efficient,
> as it avoids overhead of the crypto_shash layer. The hash computation
> itself also no longer has error codes that need to be checked.
>
> For simplicity, still do a memory allocation per operation to buffer the
> data (which is typically less than 50 bytes here) so that the one-shot
> digest functions can be used. It's still much more efficient than doing
> the super slow crypto_alloc_shash().
>
> Signed-off-by: Eric Biggers <ebiggers@xxxxxxxxxx>
Martin, could you take this via the scsi tree?
Thanks,
- Eric