Re: [PATCH] Revert "i2c: qcom-geni: Fix hardcoded clock index in SE_GENI_CLK_SEL"

[Thorsten Leemhuis]

On 10/14/26 15:17, Konrad Dybcio wrote:
> On 10/14/26 3:08 PM, Birk Skyum wrote:
>> This reverts commit cb97bf3d4f91453b881acaf8e9f0cc47bb40b604.

Andi Shyti: do you plan to pick this up and send this to Linus for 7.3?
Or should be ask him to pull this straight from here? In the latter case
it would be good to have an ACK from you.

>> With that commit the keyboard and touchpad of the Lenovo Yoga Slim 7x
>> (x1e80100) are dead, also at the disk passphrase prompt, on 7.2.9 and on
>> v7.3-rc7. The first transfer on their bus fails.
>>
>>   geni_i2c b80000.i2c: Bus proto err, noisy/unexpected start/stop
>>   i2c_hid_of 1-003a: failed to fetch HID descriptor: -5
>>
>> With the commit the I2C serial engine clocks read 32 MHz, without it
>> 19.2 MHz. A fix for the 32 MHz fast-mode timing is still being
>> discussed, so go back to the previous behaviour for 7.3. This brings
>> back the hardcoded index 0 in SE_GENI_CLK_SEL.
>>
>> On v7.3-rc7 with only i2c-qcom-geni.ko swapped, the keyboard is dead
>> without this revert and works with it.
>>
>> Fixes: cb97bf3d4f91 ("i2c: qcom-geni: Fix hardcoded clock index in SE_GENI_CLK_SEL")
>> Reported-by: Birk Skyum <birk.skyum@xxxxx>
> 
> (this looks funny because you're the author of the revert but
> it's fine I suppose)

FWIW, some subsystem maintainers don't like it. And YMMV, but I think
it's a good thing to have the extra Reported-by, as that allows to make
a distinction between "a developer found and fixed some random problem
that might or not cause issues for users" and "someone ran into a
regression and helped themselves and everybody else by directly
providing a patch"

Ciao, Thorsten

>> Closes: https://lore.kernel.org/r/179173732257.29426.7905170638383807320@xxxxx
>> Link: https://lore.kernel.org/r/ae03e7a3-75f1-42df-b0e6-0e64358be647@xxxxxxxxxxxxxxxx
>> Cc: stable@xxxxxxxxxxxxxxx
>> Signed-off-by: Birk Skyum <birk.skyum@xxxxx>
> Reviewed-by: Konrad Dybcio <konrad.dybcio@xxxxxxxxxxxxxxxx>