Re: [PATCH 0/4] ACPI: Serialize EC queries, UCSI and ideapad methods

[Rong Zhang]

Hi Ali,

On Wed, 2026-10-14 at 22:04 +0300, Ali Ahmet Memiş wrote:
> This goes on top of [1] and uses its exclusive helpers for the other
> users of the shared EC mutex in bko221065: the _Qxx methods, the UCSI
> _DSM and the ideapad-laptop methods, as discussed in [2].

Please rephrase the cover letter and the commit messages according to my
analysis in the other series.

> 
> Patches 3 and 4 depend on patch 1 and on [1], so it is probably easiest
> to take the whole set through the ACPI tree.

I don't really see the necessity of sending the two series individually.
It just made things more complicated. It'd be better to send a v2 merging
them into a single series. Once ready, each maintainer will do a subset
apply or leave an Acked-by: tag to permit applying through another
subsystem.

> 
> The ideapad part is only build-tested, so it would be great if someone
> with one of the bko221065 machines could try both series together.
> 
> [1] https://lore.kernel.org/all/20261014132703.93355-1-aliamemis@xxxxxxxxxxx/
> [2] https://lore.kernel.org/all/8be1a245-6061-4f86-9223-0da18d5e423a@xxxxxxxxxxxxxxxx/
> 
> Ali Ahmet Memiş (4):
>   ACPI: utils: Add acpi_evaluate_dsm_exclusive()

With both series merged together, you don't need a separate patch for
acpi_evaluate_dsm_exclusive() either. It can be merged into "ACPI: utils:
Add exclusive AML evaluation helpers".

>   ACPI: EC: Evaluate _Qxx methods exclusively
>   usb: typec: ucsi: acpi: Evaluate _DSM exclusively

Based on my analysis, EC queries and UCSI _DSM are just innocent victims
of the ABBA deadlock.

If solving bko221065 is the only reason why they are included in the
series, PATCH 2 and 3 are probably needless.

>   platform/x86: ideapad-laptop: Evaluate ACPI methods exclusively
> 
>  drivers/acpi/ec.c                            |  7 ++-
>  drivers/acpi/utils.c                         | 54 +++++++++++++-------
>  drivers/platform/x86/lenovo/ideapad-laptop.c | 21 ++++++--
>  drivers/usb/typec/ucsi/ucsi_acpi.c           |  8 ++-
>  include/acpi/acpi_bus.h                      |  3 ++
>  include/linux/acpi.h                         |  8 +++
>  6 files changed, 76 insertions(+), 25 deletions(-)

My comments to the other series also applies here. Please resolve them
here and there.

I will defer my tags for this series to v2.

Thanks,
Rong

> 
> 
> base-commit: 24a19b953e2a3d0ea5a8c4951a0ab8f32720c907
> prerequisite-patch-id: 4bd123d6caded06beb9a977d502370df046f82aa
> prerequisite-patch-id: 19de145660fffa3651defed4e6d536cb78418940
> prerequisite-patch-id: 01d8992be9ebc2b28dd3986fe06269eb2fe959f5