Re: [PATCH v2] mm/damon/lru_sort: fix grammar and stlye
From: SJ Park
Date: Thu Oct 15 2026 - 10:09:13 EST
On Thu, 15 Oct 2026 09:29:47 +0200 Manuel Ebner <manuelebnerli@xxxxxxxxxxx> wrote:
> Fix tenses. Split long sentences thereby imporove readability.
> Replace 'set as' with 'set to'. Replace [] with () to make the file uniform.
checkpatch.pl warns as below.
WARNING: Prefer a maximum 75 chars per line (possible unwrapped commit description?)
#10:
Replace 'set as' with 'set to'. Replace [] with () to make the file uniform.
If you don't mind, I will fix this on my end.
>
> Signed-off-by: Manuel Ebner <manuelebnerli@xxxxxxxxxxx>
Assuming you don't mind me fixing the 75 columns warning on my end,
Reviewed-by: SJ Park <sj@xxxxxxxxxx>
I applied this patch to damon/next [1] tree with the above mentioned commit
message line length fix. We are now quite close to next merge window. It may
better to focus on making mm.git more stabilized and therefore ready for the
next merge window, rather than adding more changes that are not really urgent.
I understand this series is not really urgent. Hence, Andrew might not add
this patch until next -rc1 release. In the case, I will request adding this to
mm.git after next -rc1 release. So, no action from your side is needed for
now. Let me know if you think this is really urgent.
> ---
Please add changelog on the commentary area [2], with links to the previous
revisions, from the next time.
[1] https://origin.kernel.org/doc/html/latest/mm/damon/maintainer-profile.html#scm-trees
[2] https://docs.kernel.org/process/submitting-patches.html#commentary
Thanks,
SJ
[...]