Re: [PATCH v4 08/17] KVM: TDX: Adjust the topup count of DPAMT page pairs for splitting S-EPT

From: Edgecombe, Rick P

Date: Thu Oct 15 2026 - 13:28:12 EST


On Thu, 2026-10-15 at 12:47 +0800, Yan Zhao wrote:
> > The point of spelling it all out was to make the contact clear and the
> > implementation doesn't have to assume anything about the callers.
> Hmm, but it's hard for the caller to know if private_page is true.
> We should avoid leaking TDX specific knowledge to KVM MMU, right?

Wait, why won't the caller won't know if it might map a new private page? This
is basically to cover the +1 part of the "+ 1 -1" in the calculation. I was
thinking to set it to true for normal ept violation (like an accept) and false
for split.