Re: [PATCH v2] drm/appletbdrm: Add suspend and resume support

[Lukas Wunner]

On Wed, Oct 07, 2026 at 07:50:38PM +0530, Aditya Garg wrote:
> > On 4 Oct 2026, at 5:36???PM, Aditya Garg <aditya.garg@xxxxxxxxx> wrote:
> > The driver has no USB power management callbacks, so the USB core
> > unbinds it before system suspend and binds it again on resume. The DRM
> > device is unregistered and registered again on every suspend and resume
> > cycle, userspace driving the Touch Bar through it (such as tiny-dfr)
> > loses its device, and the Touch Bar stays dark after resume.
> > 
> > Implement suspend and resume with drm_mode_config_helper_suspend() and
> > drm_mode_config_helper_resume(), so the device stays registered and the
> > last committed state is restored on resume. If the device was reset
> > while suspended, repeat the probe-time handshake first.
[...]
> Could anyone please merge it if they are ok with it? Thanks.

I'd love to, but both v1 and v2 have sashiko findings that nobody bothered
to debunk or fix.  (The fix for v1 consisted of removing a callback, which
triggered other sashiko findings.)  I'm neither an expert on this driver
nor the tiny drm library, but I'd like to help improve Linux Mac support.
Please help me understand whether the sashiko findings are valid.

Thanks,

Lukas