Re: [v11 6/7] power: supply: Add driver for ASUS Transformer battery

From: Markus Elfring

Date: Fri Oct 16 2026 - 02:11:03 EST


>> …
>>> +++ b/drivers/power/supply/asus-transformer-ec-battery.c
>>> @@ -0,0 +1,289 @@
>> …
>>> +static const unsigned int asus_ec_battery_prop_offs[] = {
>>> + [POWER_SUPPLY_PROP_STATUS] = 1,
>> …
>>> +};
>>> +
>>> +static int asus_ec_battery_get_value(struct asus_ec_battery_data *priv,
>>> + enum power_supply_property psp)
>>> +{
>>> + int ret, offs;
>> …
>>
>> The referenced array provides unsigned integers.
>> Would you like to specify a more appropriate data type for the corresponding variable?
>
> This is a nitpick, it does not affect anything.
Will consistent data type specifications be preferred in subsequent software revisions?

Regards,
Markus