Re: [PATCH v2 2/2] arm64: dts: qcom: add Xiaomi Mi 8 (dipper)

[David Heidelberg]

On 15/10/2026 11:47, Konrad Dybcio wrote:
> On 9/15/26 4:32 PM, David Heidelberg via B4 Relay wrote:
> > From: David Heidelberg <david@xxxxxxx>
> >
> > Initial submission for one member of the prime Xiaomi Mi 8 family.
> > Mi 8 Pro (equuleus) and Mi 8 Explorer (ursa) are nearly identical.
>
> [...]
>
> > + * Xiaomi Mi 8 family common device tree source.
> > + * Covers Mi 8 Explorer Edition (equuleus), Mi 8 (dipper), Mi 8 Pro (urza).
>
> 								"ursa"? ^
> [...]
>
> > +	reserved-memory {
> > +		/*
> > +		 * It seems like reserving the old rmtfs_mem region is
> > +		 * also needed to prevent random crashes
>
> Have you verified that with e.g. memtest=1?
>
> > +		 */
> > +		old-rmtfs@88f00000 {
> > +			reg = <0 0x88f00000 0 0x200000>;
>
> 0 -> 0x0, please

Isn't this a bit overkill? We just +2 chars for no gain here..

> [...]
>
> > +&tlmm {
> > +	gpio-reserved-ranges = < 0 4>, /* SPI (Goodix Fingerprint) */
>
> drop the leading space inside the value

dropped, but added space before the comment so it aligns for better readability..

David

> Konrad