Re: [PATCH v2 1/3] dt-bindings: iio: light: gp2ap002: add vled

[Linus Walleij]

On Sat, Oct 17, 2026 at 7:28 PM Christoph Rudorff <chris@xxxxxxxxxxx> wrote:

> According to datasheet page 8 "Recommended external circuit",
> it can have tree supplies: vio, vdd and vled. As vdd and vled wants the
> same voltage, they may be connected to a single supply.
>
> Signed-off-by: Christoph Rudorff <chris@xxxxxxxxxxx>
> ---
>  Documentation/devicetree/bindings/iio/light/sharp,gp2ap002.yaml | 4 ++++
>  1 file changed, 4 insertions(+)
>
> diff --git a/Documentation/devicetree/bindings/iio/light/sharp,gp2ap002.yaml b/Documentation/devicetree/bindings/iio/light/sharp,gp2ap002.yaml
> index 99bddf31cbed..f5b2c6a4d7e3 100644
> --- a/Documentation/devicetree/bindings/iio/light/sharp,gp2ap002.yaml
> +++ b/Documentation/devicetree/bindings/iio/light/sharp,gp2ap002.yaml
> @@ -33,6 +33,10 @@ properties:
>    vio-supply:
>      description: VIO power supply a phandle to a regulator
>
> +  vled-supply:

So this should be named leda-supply like the pin on the component.

> +    description: LED power supply a phandle to a regulator
> +      Optional. It may already be connected to VDD.

Description should say "LED anode power supply" as that is what the
"A" means in leda.

I'm not sure it should be optional really as it technically *must*
be connected but the diplomatic solution is to not make it
required so we don't break a ton of device trees.

If we wanna be really detail oriented, add it optional, fix all
device trees, make it non-optional.

Yours,
Linus Walleij