Re: [PATCH net 2/2] dt-bindings: net: qcom,ipq9574-ppe: Apply PPE constraints to all switch ports
From: Krzysztof Kozlowski
Date: Mon Oct 19 2026 - 02:56:06 EST
On Fri, Oct 16, 2026 at 05:01:40PM +0200, Til Kaiser wrote:
> The generic ethernet-switch schema accepts both ports and ethernet-ports
> containers and both port and ethernet-port child nodes. The PPE binding
> only applies its port constraints to ethernet-port nodes with addresses
> matching [1-6]+ inside ethernet-ports.
>
> As a result, ethernet-port@7 with reg = <7> is accepted without the PPE
> port ID limit. The alternative container and child naming forms also
> bypass the required PPE clocks and resets.
>
> Match the same container and child node patterns as ethernet-switch.yaml
> so that every accepted switch port receives the PPE constraints. Keep
> the valid port IDs constrained by reg.
>
> Fixes: 1898fc572118 ("dt-bindings: net: Add PPE for Qualcomm IPQ9574 SoC")
Nothing to be fixed here, really, drop.
> Signed-off-by: Til Kaiser <mail@xxxxxxxx>
> ---
> Documentation/devicetree/bindings/net/qcom,ipq9574-ppe.yaml | 5 +++--
> 1 file changed, 3 insertions(+), 2 deletions(-)
>
> diff --git a/Documentation/devicetree/bindings/net/qcom,ipq9574-ppe.yaml b/Documentation/devicetree/bindings/net/qcom,ipq9574-ppe.yaml
> index 6d0b21a10732..a5e8aab500ed 100644
> --- a/Documentation/devicetree/bindings/net/qcom,ipq9574-ppe.yaml
> +++ b/Documentation/devicetree/bindings/net/qcom,ipq9574-ppe.yaml
> @@ -173,9 +173,10 @@ properties:
> - interrupts
> - interrupt-names
>
> - ethernet-ports:
> +patternProperties:
> + "^(ethernet-)?ports$":
Why are you reverting the review? The name is ethernet-ports.
> patternProperties:
> - "^ethernet-port@[1-6]+$":
> + "^(ethernet-)?port@[0-9a-f]+$":
Same here.
Best regards,
Krzysztof