Re: [PATCH net-next 1/5] dt-bindings: net: add support for Toshiba TC9564

[Andrew Lunn]

> +  snps,tso:
> +    $ref: /schemas/types.yaml#/definitions/flag
> +    description:
> +      Enable TCP segmentation offload.

snps,dwmac.yaml 

  snps,tso:
    $ref: /schemas/types.yaml#/definitions/flag
    description:
      Enables the TSO feature otherwise it will be managed by MAC HW capability
      register.

> +
> +  snps,pbl:
> +    $ref: /schemas/types.yaml#/definitions/uint32
> +    description:
> +      Set the programmable burst length.

  snps,pbl:
    description:
      Programmable Burst Length (tx and rx)
    $ref: /schemas/types.yaml#/definitions/uint32
    enum: [1, 2, 4, 8, 16, 32]

> +  snps,force_sf_dma_mode:
> +    $ref: /schemas/types.yaml#/definitions/flag
> +    description:
> +      Force store-and-forward mode for both TX and RX DMA.

  snps,force_sf_dma_mode:
    $ref: /schemas/types.yaml#/definitions/flag
    description:
      Force DMA to use the Store and Forward mode for both tx and
      rx. This flag is ignored if force_thresh_dma_mode is set.


You should be using snps,dwmac.yaml to provide all of these.

> +  phy-mode:
> +    const: sgmii

This device support 10GBase-R? So why in the binding only allow SGMII?

	Andrew