Re: [PATCH 1/2] dt-bindings: arm: fsl: add i.MX937 FRDM board

[Marco Felsch]

Hi Joy,

On 26-10-19 19:10, Joy Zou wrote:
> Add DT compatible string for NXP i.MX937 FRDM board.
> 
> Signed-off-by: Joy Zou <joy.zou@xxxxxxxxxxx>
> ---
>  Documentation/devicetree/bindings/arm/fsl.yaml | 7 +++++++
>  1 file changed, 7 insertions(+)
> 
> diff --git a/Documentation/devicetree/bindings/arm/fsl.yaml b/Documentation/devicetree/bindings/arm/fsl.yaml
> index c8290a83205b..af10cac62f90 100644
> --- a/Documentation/devicetree/bindings/arm/fsl.yaml
> +++ b/Documentation/devicetree/bindings/arm/fsl.yaml
> @@ -1570,6 +1570,13 @@ properties:
>            - const: toradex,osm-imx93
>            - const: fsl,imx93
>  
> +      - description: i.MX937 based Boards
> +        items:
> +          - enum:
> +              - fsl,imx937-frdm           # i.MX937 FRDM Board
> +          - const: fsl,imx937
> +          - const: fsl,imx952

At least to me it seems odd that you specify two SoC compatibles here.

Side note (obviously not something you could influence):

NXP should really work on their product family names. If some
i.mx95<foo> is compatible with i.mx95<bla> I would call it i.mx95<foo>
and not i.mx93<foo>.

Regards,
  Marco

> +
>        - description: i.MX94 based Boards
>          items:
>            - enum:
> 
> -- 
> 2.34.1
> 
> 
>