Re: [PATCH 3/5] tools/vm: rename tools/vm to tools/mm

[SJ Park]

Hello Dan,

On Mon, 19 Oct 2026 15:36:14 +0300 Dan Carpenter <error27@xxxxxxxxx> wrote:

> On Tue, Jan 03, 2023 at 06:07:52PM +0000, SeongJae Park wrote:
> > Rename tools/vm to tools/mm for being more consistent with the code and
> > documentation directories, and won't be confused with virtual machines.
> > 
> > Signed-off-by: SeongJae Park <sj@xxxxxxxxxx>
> > ---
> >  Documentation/admin-guide/mm/idle_page_tracking.rst | 2 +-
> >  Documentation/admin-guide/mm/pagemap.rst            | 4 ++--
> >  Documentation/mm/page_owner.rst                     | 2 +-
> >  Documentation/mm/slub.rst                           | 2 +-
> >  Documentation/translations/zh_CN/mm/page_owner.rst  | 2 +-
> >  MAINTAINERS                                         | 2 +-
> >  mm/Kconfig.debug                                    | 2 +-
> >  mm/memory-failure.c                                 | 2 +-
> >  tools/{vm => mm}/.gitignore                         | 0
> >  tools/{vm => mm}/Makefile                           | 0
> >  tools/{vm => mm}/page-types.c                       | 0
> >  tools/{vm => mm}/page_owner_sort.c                  | 0
> >  tools/{vm => mm}/slabinfo-gnuplot.sh                | 0
> >  tools/{vm => mm}/slabinfo.c                         | 0
> >  14 files changed, 9 insertions(+), 9 deletions(-)
> >  rename tools/{vm => mm}/.gitignore (100%)
> >  rename tools/{vm => mm}/Makefile (100%)
> >  rename tools/{vm => mm}/page-types.c (100%)
> >  rename tools/{vm => mm}/page_owner_sort.c (100%)
> >  rename tools/{vm => mm}/slabinfo-gnuplot.sh (100%)
> >  rename tools/{vm => mm}/slabinfo.c (100%)
> 
> Is there a reason we left the tools/vm directory even though
> it's empy?  Is it for backwards compatability or something?

No, I think this patch didn't leave tools/vm/.  I cannot see that on my tree:

    $ git log -1 799fb82aa132fa3a3886b7872997a5a84e820062
    commit 799fb82aa132fa3a3886b7872997a5a84e820062 (HEAD)
    Author: SeongJae Park <sj@xxxxxxxxxx>
    Date:   Tue Jan 3 18:07:52 2023 +0000
    
        tools/vm: rename tools/vm to tools/mm
    
        Rename tools/vm to tools/mm for being more consistent with the code and
        documentation directories, and won't be confused with virtual machines.
    
        Link: https://lkml.kernel.org/r/20230103180754.129637-4-sj@xxxxxxxxxx
        Signed-off-by: SeongJae Park <sj@xxxxxxxxxx>
        Cc: Jonathan Corbet <corbet@xxxxxxx>
        Cc: Shuah Khan <shuah@xxxxxxxxxx>
        Signed-off-by: Andrew Morton <akpm@xxxxxxxxxxxxxxxxxxxx>
    $ git show 799fb82aa132fa3a3886b7872997a5a84e820062:tools/vm
    fatal: path 'tools/vm' does not exist in '799fb82aa132fa3a3886b7872997a5a84e820062'

If your local tree has some git-untracked hidden files under tools/vm/
directory, the directory might not be removed.  That could made you think this
patch left the directory?


Thanks,
SJ

[...]