Re: [PATCH v4 2/6] watchdog: w83627hf_wdt: Replace magic numbers with descriptive macros
From: Tzung-Bi Shih
Date: Mon Oct 19 2026 - 12:14:08 EST
On Tue, Oct 13, 2026 at 03:58:46PM +0200, Paul Louvel wrote:
> Raw hex values for Super I/O register addresses are difficult to
> understand
> without constantly consulting the datasheet. Use named macros instead.
> Also, replace macros value that contains bit position with the BIT()
> macro.
> Remove comments that doesn't help understanding the code.
>
> Signed-off-by: Paul Louvel <paul.louvel@xxxxxxxxxxx>
This looks good to me. Except for a weird line wrap in the commit message,
Reviewed-by: Tzung-Bi Shih <tzungbi@xxxxxxxxxx>