Re: [PATCH v4 2/2] kallsyms: Don't leak pointers for unresolved symbols

[Sebastian Andrzej Siewior]

On 2026-10-19 17:34:02 [+0200], Petr Mladek wrote:
> > --- a/kernel/kallsyms.c
> > +++ b/kernel/kallsyms.c
> > @@ -483,7 +483,8 @@ static int __sprint_symbol(char *buffer, unsigned long address,
> >  	len = kallsyms_lookup_buildid(address, &size, &offset, &modname, &buildid,
> >  				       buffer);
> >  	if (!len)
> > -		return sprintf(buffer, "0x%lx", address - symbol_offset);
> > +		return snprintf_default_pointer(buffer, KSYM_SYMBOL_LEN,
> > +						(void *)(address - symbol_offset));
> 
> I do not see any obvious problem with using:
> 
> 	return snprintf(buffer, KSYM_SYMBOL_LEN, "%p",
> 			(void *)(address - symbol_offset));
> 
> What was the motivation to create a custom wrapper, please?

Overseeing the simple solution.

> Best Regards,
> Petr

Sebastian