Re: [PATCH] cpufreq: longrun: fix typo in kernel-doc

[Zhongqiu Han]

On 10/19/2026 4:51 PM, Manuel Ebner wrote:
> On Mon, 2026-10-19 at 11:37 +0800, Zhongqiu Han wrote:
> > Hi Manuel,
> >
> > Thanks for the patch.
> >
> > On 10/17/2026 3:14 PM, Manuel Ebner wrote:
> > > Fix typo to fix:
> > >
> > >     $ ./scripts/kernel-doc -none drivers/cpufreq/longrun.c
> > >     Warning: drivers/cpufreq/longrun.c:126 expecting prototype for longrun_verify_poliy(). Prototype was for longrun_verify_policy() instead
> >
> > ./scripts/checkpatch.pl reports a warning which should be acceptable to
> > keep unwrapped as it is tool output.
> >
> > WARNING: Prefer a maximum 75 chars per line (possible unwrapped commit
> > description?)
> > #9:
> >     Warning: drivers/cpufreq/longrun.c:126 expecting prototype for
> > longrun_verify_poliy(). Prototype was for longrun_verify_policy() instead
> >
> > total: 0 errors, 1 warnings, 8 lines checked
> >
> >
> >
> > Also, while reproducing this issue, I noticed another problem,
> >
> > ./scripts/kernel-doc -none drivers/cpufreq/longrun.c
> > Warning: drivers/cpufreq/longrun.c:21 This comment starts with '/**',
> > but isn't a kernel-doc comment. Refer to
> > Documentation/doc-guide/kernel-doc.rst
> >    * longrun_{low,high}_freq is needed for the conversion of cpufreq kHz
> >
> > It should use /* instead of /** and may be worth a separate patch.
>
> Will do.

Thanks

> > But
> > since this patch is only intended to fix the typo, the patch itself
> > looks fine to me.
> >
> > > Signed-off-by: Manuel Ebner <manuelebnerli@xxxxxxxxxxx>
> >
> > Small nit: please consider to add the Fixes tag:
> > Fixes: 1da177e4c3f4 ("Linux-2.6.12-rc2")
>
> Well, thats the init commit, should it still be added in
> future patches?
> Can pre-git history be referenced?

AFAIK, yes, the usual approach for pre-Git history is to use
Fixes: 1da177e4c3f4 ("Linux-2.6.12-rc2"), the initial Git commit.
Many patches have used this Fixes tag, for example:

https://lore.kernel.org/all/?q=1da177e4c3f4

> > Reviewed-by: Zhongqiu Han <zhongqiu.han@xxxxxxxxxxxxxxxx>
>
> Thanks
>   Manuel
>
> > ...


--
Thx and BRs,
Zhongqiu Han