Re: [PATCH 2/7] dt-bindings: phy: qcom: Add qcom,sa8775p-csi2-phy schema
From: Krzysztof Kozlowski
Date: Tue Oct 20 2026 - 01:54:41 EST
On 19/10/2026 09:25, Nihal Kumar Gupta wrote:
>
>
> On 19-10-2026 12:43, Krzysztof Kozlowski wrote:
>>> DTS uses 2-cell reg but binding example uses 1-cell. Please align:
>>> reg = <0x0 0x0ac9c000 0x0 0x2000>;
>> I don't understand what is supposed to be aligned here. The code is
>> correct.
> Right, the DTS change is correct.
>
> My comment was about the binding example using a different address/size cell
> layout from the real DTS.
>
> Krzysztof, should the binding example mirror the SoC bus address/size cell
Why are you suggesting in review something which maintainers never
suggested? Or actually opposite to what some maintainers were suggesting
before. Code has correct example.
Best regards,
Krzysztof