Re: [PATCH 1/2] dt-bindings: usb: fsa4480: Add an optional audio port/endpoint

[Krzysztof Kozlowski]

On Sun, Oct 18, 2026 at 07:58:56PM -0300, Val Packett wrote:
> To actually support analog audio output, the fsa4480 driver needs to
> deliver the hotplug notifications over the Type-C graph to an audio
> codec driver. Describe a second port intended for the codec. Keep it
> optional to make sure existing device trees do still validate.

Argumentation is questionable. We do not add bindings/DTS to represent
driver needs, but actual hardware connections, so please rephrase. See
qcom,wcd9390-usbss for examples, as it is the same block basically.

> 
> Signed-off-by: Val Packett <val@xxxxxxxxxxxx>
> ---
>  .../devicetree/bindings/usb/fcs,fsa4480.yaml  | 90 +++++++++++++------
>  1 file changed, 63 insertions(+), 27 deletions(-)
> 
> diff --git a/Documentation/devicetree/bindings/usb/fcs,fsa4480.yaml b/Documentation/devicetree/bindings/usb/fcs,fsa4480.yaml
> index 89b1fb90aeeb..9dfe95b6adf3 100644
> --- a/Documentation/devicetree/bindings/usb/fcs,fsa4480.yaml
> +++ b/Documentation/devicetree/bindings/usb/fcs,fsa4480.yaml
> @@ -9,31 +9,11 @@ title: ON Semiconductor Analog Audio Switch
>  maintainers:
>    - Bjorn Andersson <bjorn.andersson@xxxxxxxxxx>
>  
> -properties:
> -  compatible:
> -    oneOf:
> -      - const: fcs,fsa4480
> -      - items:
> -          - enum:
> -              - ocs,ocp96011
> -          - const: fcs,fsa4480
> -
> -  reg:
> -    maxItems: 1
> -
> -  interrupts:
> -    maxItems: 1
> -
> -  vcc-supply:
> -    description: power supply (2.7V-5.5V)
> -
> -  mode-switch: true
> -  orientation-switch: true
> -
> -  port:
> +$defs:
> +  controller-port:
>      $ref: /schemas/graph.yaml#/$defs/port-base
>      description:
> -      A port node to link the FSA4480 to a TypeC controller for the purpose of
> +      A port node to link the FSA4480 to a Type-C controller for the purpose of
>        handling altmode muxing and orientation switching.
>      unevaluatedProperties: false
>  
> @@ -69,15 +49,56 @@ properties:
>                    - AUX+ connected to SBU2
>                    - AUX- connected to SBU1
>  
> +properties:
> +  compatible:
> +    oneOf:
> +      - const: fcs,fsa4480
> +      - items:
> +          - enum:
> +              - ocs,ocp96011
> +          - const: fcs,fsa4480
> +
> +  reg:
> +    maxItems: 1
> +
> +  interrupts:
> +    maxItems: 1
> +
> +  vcc-supply:
> +    description: power supply (2.7V-5.5V)
> +
> +  mode-switch: true
> +  orientation-switch: true
> +
> +  port:
> +    $ref: "#/$defs/controller-port"
> +
> +  ports:
> +    $ref: /schemas/graph.yaml#/properties/ports
> +    properties:
> +      port@0:
> +        $ref: "#/$defs/controller-port"
> +      port@1:
> +        $ref: /schemas/graph.yaml#/$defs/port-base
> +        description:
> +          A port node to link the FSA4480 to an audio codec in order to
> +          notify it whenever an analog audio adapter is plugged/unplugged.

Same here

Best regards,
Krzysztof