Re: [PATCH 1/4] arm64: dts: qcom: msm8917-xiaomi-wingtech: add notification led
From: Konrad Dybcio
Date: Tue Oct 20 2026 - 04:12:17 EST
On 9/21/26 7:43 PM, Barnabás Czémán wrote:
> Add the aw2013 led-controller node for controlling the notification LED.
But it's already present!
[...]
> +&blsp1_i2c2 {
> + aw2013: led-controller@45 {
> + compatible = "awinic,aw2013";
> + reg = <0x45>;
> + vcc-supply = <&pm8937_l10>;
> + vio-supply = <&pm8937_l5>;
> + #address-cells = <1>;
> + #size-cells = <0>;
> +
> + status = "disabled";
> + };
This feels a little sloppy. Either disabling it where necessary
(presumably a small subset) or moving the definition to the places
that use it (if *that* is a smaller subset) sounds cleaner
Konrad