Re: [PATCH 1/1] dt-bindings: spi: Add separate binding for dh,dhcom-board

[Frank Li]

On Tue, Oct 20, 2026 at 01:33:24PM +0000, Christoph Niedermaier wrote:
> From: Conor Dooley <conor@xxxxxxxxxx>
> Sent: Monday, October 19, 2026 8:23 PM
> > On Sun, Oct 18, 2026 at 11:38:09PM +0200, Marek Vasut wrote:
> > > On 10/18/26 9:37 PM, Conor Dooley wrote:
> > > > On Sat, Oct 17, 2026 at 12:01:55AM +0200, Marek Vasut wrote:
> > > > > On 10/16/26 10:57 PM, Frank.Li@xxxxxxxxxxx wrote:
> > > > > > From: Frank Li <Frank.Li@xxxxxxx>
> > > > > >
> > > > > > The dh,dhcom-board SPI device uses spi-cpha and spi-cpol properties,
> > > > > > which are not permitted by the trivial-devices schema. Move it to a
> > > > > > dedicated binding file that references spi-peripheral-props.yaml and
> > > > > > explicitly allows those SPI mode properties.
> > > > > >
> > > > > > Fixes below CHECK_DTBS warnings:
> > > > > >     arch/arm/boot/dts/nxp/imx/imx6ull-dhcor-maveo-box.dtb: spidev@0 (dh,dhcom-board): 'spi-cpha', 'spi-cpol' do not match any of the regexes: '^pinctrl-[0-9]+$'
> > > > > >           from schema $id: http://devicetree.org/schemas/trivial-devices.yaml
> > > > >
> > > > > How come this did not trigger until now ?
> > > > >
> > > > > > Assisted-by: LLM
> > > > > > Signed-off-by: Frank Li <Frank.Li@xxxxxxx>
> > > > > > ---
> > > > > >    .../bindings/spi/dh,dhcom-board.yaml          | 46 +++++++++++++++++++
> > > > > >    .../devicetree/bindings/trivial-devices.yaml  |  2 -
> > > > > >    2 files changed, 46 insertions(+), 2 deletions(-)
> > > > > >    create mode 100644 Documentation/devicetree/bindings/spi/dh,dhcom-board.yaml
> > > > > >
> > > > > > diff --git a/Documentation/devicetree/bindings/spi/dh,dhcom-board.yaml b/Documentation/devicetree/bindings/spi/dh,dhcom-board.yaml
> > > > > > new file mode 100644
> > > > > > index 0000000000000..ed213cbe9b04c
> > > > > > --- /dev/null
> > > > > > +++ b/Documentation/devicetree/bindings/spi/dh,dhcom-board.yaml
> > > > > > @@ -0,0 +1,46 @@
> > > > > > +# SPDX-License-Identifier: GPL-2.0-only OR BSD-2-Clause
> > > > > > +%YAML 1.2
> > > > > > +---
> > > > > > +$id: http://devicetree.org/schemas/spi/dh,dhcom-board.yaml#
> > > > > > +$schema: http://devicetree.org/meta-schemas/core.yaml#
> > > > > > +
> > > > > > +title: DH electronics GmbH on-board CPLD trivial SPI device
> > > > >
> > > > > This does not look quite right, since compatible this is used only on:
> > > > >
> > > > > arch/arm/boot/dts/imx6ull-dhcor-maveo-box.dts
> > > > >
> > > > >         model = "DH electronics i.MX6ULL DHCOR on maveo box";
> > > > >         compatible = "marantec,imx6ull-dhcor-maveo-box",
> > > > > "dh,imx6ull-dhcor-som",
> > > > >
> > > > > So the whole
> > > > >
> > > > >         spidev@0 {
> > > > >                 compatible = "dh,dhcom-board";
> > > > >                 reg = <0>;
> > > > >                 spi-cpha;
> > > > >                 spi-cpol;
> > > > >                 spi-max-frequency = <54000000>;
> > > > >         };
> > > > >
> > > > > Should probably use a different compatible.
> > > > >
> > > > > Christoph, what device is this on this board ?
>
> There is no device connected to these pins, only an extension connector.
> The "dh,dhcom-board" device was used only to test the hardware and was
> unfortunately forgotten to be removed. In the production version, no
> device is connected to this interface. It should actually be removed.
> Should I create a patch for this?

Yes, thanks

Frank