Re: [PATCH] ktest: Accept quoted bad term in git bisect output

[Steven Rostedt]

On Fri, 09 Oct 2026 22:13:23 -0300
Ricardo B. Marlière (SUSE) <ricardo@xxxxxxxxxxxx> wrote:

> Git commit 0c0f93e7fa64 ("bisect: print bisect terms in single quotes")
> changed the completion message to put single quotes around the bisect term.
> run_git_bisect() only recognizes "is the first bad commit", so it misses
> completion and continues the bisect loop with newer Git.
> 
> Accept both quoted and unquoted forms to retain compatibility with older
> Git versions.
> 
> Link: https://git.kernel.org/pub/scm/git/git.git/commit/?id=0c0f93e7fa645c1058226a9bfde9e2b4441edf96
> Assisted-by: LLM

I'm guessing you let an LLM fix this?

> Signed-off-by: Ricardo B. Marlière (SUSE) <ricardo@xxxxxxxxxxxx>
> ---
>  tools/testing/ktest/ktest.pl | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/tools/testing/ktest/ktest.pl b/tools/testing/ktest/ktest.pl
> index f94ed2e98887..9d63a1dcdb3e 100755
> --- a/tools/testing/ktest/ktest.pl
> +++ b/tools/testing/ktest/ktest.pl
> @@ -3019,7 +3019,7 @@ sub run_git_bisect {
>      doprint "SUCCESS\n";
>      if ($output =~ m/^(Bisecting: .*\(roughly \d+ steps?\))\s+\[([[:xdigit:]]+)\]/) {
>  	doprint "$1 [$2]\n";
> -    } elsif ($output =~ m/^([[:xdigit:]]+) is the first bad commit/) {
> +    } elsif ($output =~ m/^([[:xdigit:]]+) is the first (?:bad|'bad') commit/) {

Please nuke the "?:" from the above. It's not needed and I never use it. It
only makes the code more complex. Yes, it's because we don't care about
saving what is in the "()", but I never remember how to do that and thus I
never do. The perl code in ktest.pl is meant to be easy to read by those
that know sed and C, and things like this just make it hard to understand.

Thanks,

-- Steve



>  	$bisect_bad_commit = $1;
>  	doprint "Found bad commit... $1\n";
>  	return 0;
> 
> ---
> base-commit: af32da41b0327b9c6a37856ba82b6760d6c8d10e
> change-id: 20261009-ktest-git-bisect-a894f472843e
> 
> Best regards,
> --  
> Ricardo B. Marlière (SUSE) <ricardo@xxxxxxxxxxxx>