Re: [PATCH v4] usb: ohci-omap: implement overcurrent handling for GPIO-based power control
From: Andreas Kemnade
Date: Tue Oct 20 2026 - 16:27:34 EST
On Mon, 19 Oct 2026 19:45:15 +0330
Muhammad Mahdi Amirpour <ampr.mhd@xxxxxxxxx> wrote:
> I do not have the hardware to test this patch, so I cannot verify it
> at runtime. Given that this is a legacy driver, I am happy to drop
> this patch and work on something else if you think that would be
> better. Otherwise, I can send a v5 addressing the Sashiko bot findings
> (the IRQ handler ordering and the probe falling-edge race).
>
> Please let me know how you would like to proceed.
So this patch practically only used on omap1, it does not improve
maintainability (e.g. by removing the last user of some API) or
apparently not a critical bug. So it should be tested.
It should probably not be first priority to implement something you
cannot test.
@Aaro do you think that improves something valuable?
Regards,
Andreas