Re: [PATCH v3 7/7] i2c: qcom-cci: Build command words with FIELD_PREP()

[Konrad Dybcio]

On 10/16/26 10:00 AM, Loic Poulain wrote:
> Every command loaded into the CCI command queue has the same shape: a
> 4-bit opcode in the low nibble followed by an opcode specific payload.
> That payload was open-coded as a bare shift at each site, which hides
> how wide the fields actually are.
> 
> Describe the fields and use FIELD_PREP() instead. No functional change.
> 
> Suggested-by: Konrad Dybcio <konrad.dybcio@xxxxxxxxxxxxxxxx>
> Signed-off-by: Loic Poulain <loic.poulain@xxxxxxxxxxxxxxxx>
> ---

Reviewed-by: Konrad Dybcio <konrad.dybcio@xxxxxxxxxxxxxxxx>

Konrad