Re: [PATCH] net: sfc: run hardware-classified UDP packets through GRO

[Paolo Abeni]

On 10/19/26 15:38, Edward Cree wrote:
> On 18/10/2026 22:05, Michael Baikov via B4 Relay wrote:
> > From: Michael Baikov <manpacket@xxxxxxxxx>
> >
> > This commit partially undoes changes made by the commit e79255de8581
> > ("sfc: Do not pass non-TCP packets into GRO code"). Those changes made
> > sense back then, but now GRO can help with more message types. Instead
> > of passing just TCP packets driver to GRO now also pass UDP packets.
> >
> > Tested on SFC9250 with a UDP_GRO socket.
> >
> > Signed-off-by: Michael Baikov <manpacket@xxxxxxxxx>
>
> This seems sensible enough, but I wonder whether, instead of doing GRO
>   on TCP|UDP, it would be better at this point to just pass all protocols
>   to GRO and not try to be clever about it in the driver.  I don't know
>   how likely other ipprotos are to grow GRO support in the future, or
>   whether the front-end check in the driver (potentially adding cycles to
>   every RX) is more expensive than having random IP go partway up the GRO
>   stack to then be kicked out onto the non-GRO RX path, given that
>   there's not likely to be much high-rate traffic that's neither TCP nor
>   UDP (whereas when we wanted to separate those two there was potentially
>   much more value in doing so early).
> So on those grounds I think there's a case for a straight revert of
>   e79255de8581, 

I also agree a clean revert would be the better option.

Please note we are in the merge window right now, you need to wait
until net-next re-opens for the new revision.

/P