Re: [PATCH 3/5] firmware: qcom: Add an TEE bus based ICE back-end

[Konrad Dybcio]

On 10/21/26 5:43 PM, Harshal Dev wrote:
> Add support for a TEE client driver which forwards calls from the Inline
> Crypto Engine (ICE) service (invoked by the ICE driver) to the OPTEE ICE
> Psuedo-TA.

LLM says: typo: "Psuedo"; s/an TEE bus/a TEE bus

> The ICE PTA supports both ICE Legacy and Standard modes. In Standard mode
> Hardware Key Manager v1 is supported.
> 
> Signed-off-by: Harshal Dev <harshal.dev@xxxxxxxxxxxxxxxx>
> ---

[...]

> +config QCOM_ICE_TEE
> +       tristate
> +       select QCOM_ICE_SERVICE
> +       depends on TEE
> +       depends on !CPU_BIG_ENDIAN
> +       default m if ARCH_QCOM
> +       help
> +         Enable the generic Inline Crypto Engine (ICE) firmware service TEE
> +         implementation as a backend.

LLM says: please use tabs here

Konrad