Re: [PATCH v1 4/8] arm64: dts: qcom: hawi: add LPASS audio subsystem nodes

[Konrad Dybcio]

On 9/23/26 10:46 AM, Prasad Kumpatla wrote:
> Add the Low Power Audio SubSystem (LPASS) device tree infrastructure
> for Hawi to describe the ADSP-based audio pipeline.
> 
> Add the GPR (Generic Packet Router) node with q6apm and q6prm audio
> services, LPASS RX, TX and VA macro codecs, SoundWire controllers,
> VA CSR clock provider, and LPI TLMM pinctrl node required by the audio
> subsystem.
> 
> Signed-off-by: Prasad Kumpatla <prasad.kumpatla@xxxxxxxxxxxxxxxx>
> ---

[...]

> +		lpass_rxmacro: codec@72c0000 {
> +			compatible = "qcom,hawi-lpass-rx-macro";
> +			reg = <0x0 0x072c0000 0x0 0x1000>;
> +			clocks = <&q6prmcc LPASS_CLK_ID_RX_CORE_TX_MCLK LPASS_CLK_ATTRIBUTE_COUPLE_NO>,
> +				 <&q6prmcc LPASS_HW_LPR_VOTE LPASS_CLK_ATTRIBUTE_COUPLE_NO>,
> +				 <&q6prmcc LPASS_HW_DCODEC_VOTE LPASS_CLK_ATTRIBUTE_COUPLE_NO>,
> +				 <&lpass_vamacro>;
> +			clock-names = "mclk", "lpr", "dcodec", "fsgen";

1 entry a line would be perfect, in all cases

Otherwise I think this lgtm

Reviewed-by: Konrad Dybcio <konrad.dybcio@xxxxxxxxxxxxxxxx>

Konrad