Re: [PATCH] staging: greybus: Use fsleep() for delay
From: Johan Hovold
Date: Thu Oct 22 2026 - 07:29:10 EST
On Thu, Oct 22, 2026 at 04:32:38PM +0530, pavankumaryalagada@xxxxxxxxx wrote:
> From: Yalagada Pavan Kumar <pavankumaryalagada@xxxxxxxxx>
>
> In the loopback function, usleep_range() is used for short delays
> and msleep() for longer delays. This requires choosing the delay
> function based on the requested time and converting microseconds
> to milliseconds when using msleep().
Please include the module in Subject since this is not a subsystem wide
change:
staging: greybus: loopback: ...
> Replace both functions with fsleep(), which selects a suitable
> delay method based on the requested time. This avoids the need
> to choose the delay function and convert the time manually.
It probably doesn't matter here, but I think you should mentioned that
fsleep() will likely make short sleeps longer (25% instead of 100 us
slack).
Johan