Re: [PATCH 3/3] arm64: dts: qcom: msm8916-samsung-j5: Add proximity sensor

From: Konrad Dybcio

Date: Thu Oct 22 2026 - 09:52:46 EST


On 10/22/26 3:35 PM, chr[] wrote:
> Am 16.10.26 um 17:11 schrieb Konrad Dybcio:
>> On 10/16/26 4:43 PM, Christoph Rudorff wrote:
>>> J5 got a gp2ap002 sensor, add it and it's supplies to the device tree
>>>
>>> Signed-off-by: Christoph Rudorff <chris@xxxxxxxxxxx>
>>> ---
>>>   .../boot/dts/qcom/msm8916-samsung-j5-common.dtsi   | 19 ++++++++++
>>>   arch/arm64/boot/dts/qcom/msm8916-samsung-j5.dts    | 40 ++++++++++++++++++++++
>>
>> It's odd for the regulator and pin setting to be common, but the
>> sensor to only be there for one of these devices
>>
>> Konrad
>
> Hi Konrad,
>
> in patchv3 I removed the settings from common
> and renamed some labels.
>
> Is that ok?

I guess we'll see when you send it?

Konrad