Re: [PATCH 0/5] timekeeping: Reduce magnitude of ntp_error

From: Miroslav Lichvar

Date: Thu Oct 22 2026 - 09:58:43 EST


On Thu, Oct 22, 2026 at 11:05:18AM +0200, Rodolfo Giometti wrote:
> On 21/10/26 16:37, David Woodhouse wrote:
> > Ping? Patches 1-4 of this should be ready to merge now.
> >
> > So is number 5 as far as I'm concerned, but I'm happy to entertain
> > further discussion if anyone has an opinion they want to share.
>
> Number 5 changes the timestamps PPS_FETCH returns to userspace, so I'd
> still like an explicit OK from its users, such as chrony and others,
> before it goes in.

I'm ok with it. As described, I don't think it's going to cause any
issues, especially for low-rate PPS, but I don't like much that the
clock is inconsistent with other sources of timestamps that the
application is getting. That can be addressed later.

For the PTP_SYS_OFFSET_EXTENDED ioctl, is there a possibility the
application could see an out-of-order system clock timestamp in the
list?

--
Miroslav Lichvar