Re: [PATCH 3/5] timekeeping: Bound idle sleep while a phase slew is in flight

From: John Stultz

Date: Thu Oct 22 2026 - 17:14:46 EST


On Thu, Oct 1, 2026 at 1:21 PM David Woodhouse <dwmw2@xxxxxxxxxxxxx> wrote:
>
> From: David Woodhouse <dwmw@xxxxxxxxxxxx>
>
> Phase offset for adjtime() can be delivered at a rate of 500µs/s, and
> for STA_PPSTIME potentially even more. The skew is recalculated in
> second_overflow() each second, and if that's missed in a tickless
> kernel, the skew continues to be applied for the whole of the idle
> period. While skew is active, clamp timekeeping_max_deferment() to the
> top of the current second to avoid the overshoot.
>
> Signed-off-by: David Woodhouse <dwmw@xxxxxxxxxxxx>
> Assisted-by: LLM

So, again, this looks ok at a high level to me, but I've not really
worked through the __do_adjtimex changes.

My only hesitancy is shashiko has thoughts but I haven't quite sorted
out if its a real issue or not:
https://sashiko.dev/#/patchset/20261001202134.33929-1-dwmw2%40infradead.org?part=3

But assuming you've evaluated and dismissed that concern:
Acked-by: John Stultz <jstultz@xxxxxxxxxx>

thanks
-john