Re: [PATCH 2/3] dt-bindings: iio: cdc: add Texas Instruments FDC1004

[Jonathan Cameron]

On Thu, 22 Oct 2026 18:40:31 -0500
Victor Chernyakin <chernyakin.victor.j@xxxxxxxxxxx> wrote:

> Add device tree bindings for the Texas Instruments FDC1004
> capacitive sensor.
> 
> Signed-off-by: Victor Chernyakin <chernyakin.victor.j@xxxxxxxxxxx>
> ---
>  .../bindings/iio/cdc/ti,fdc1004.yaml          | 44 +++++++++++++++++++
>  MAINTAINERS                                   |  5 +++
>  2 files changed, 49 insertions(+)
>  create mode 100644 Documentation/devicetree/bindings/iio/cdc/ti,fdc1004.yaml
> 
> diff --git a/Documentation/devicetree/bindings/iio/cdc/ti,fdc1004.yaml b/Documentation/devicetree/bindings/iio/cdc/ti,fdc1004.yaml
> new file mode 100644
> index 000000000000..d22b7bc92a3f
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/iio/cdc/ti,fdc1004.yaml
> @@ -0,0 +1,44 @@
> +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
> +%YAML 1.2
> +---
> +$id: http://devicetree.org/schemas/iio/cdc/ti,fdc1004.yaml#
> +$schema: http://devicetree.org/meta-schemas/core.yaml#
> +
> +title: Texas Instruments FDC1004 capacitive sensor
> +
> +maintainers:
> +  - Victor Chernyakin <chernyakin.victor.j@xxxxxxxxxxx>
> +
> +description: |
> +  The FDC1004 is a high-resolution 4-channel capacitance to digital converter
> +  that works over I2C.
> +
> +  https://www.ti.com/product/FDC1004
> +
> +properties:
> +  compatible:
> +    const: ti,fdc1004
> +
> +  reg:
> +    maxItems: 1
> +
> +  vdd-supply: true
> +
> +required:
> +  - compatible
> +  - reg

Require the power supply.  The binding reflects that the sensor needs
power to operate.

> +
> +additionalProperties: false
> +
> +examples:
> +  - |
> +    i2c {
> +        #address-cells = <1>;
> +        #size-cells = <0>;
> +
> +        cdc@50 {
> +            compatible = "ti,fdc1004";

As I mention in the driver review, I think this sort of sensor is pretty
much always wired up to specific external sensing elements. As such you
may want to provide channel sub nodes in here to make it discoverable
which channels are actually useful.

> +            reg = <0x50>;
> +        };
> +    };
> +...
> diff --git a/MAINTAINERS b/MAINTAINERS
> index 360977678f70..69c23ae21016 100644
> --- a/MAINTAINERS
> +++ b/MAINTAINERS
> @@ -27388,6 +27388,11 @@ S:	Maintained
>  F:	drivers/net/ethernet/ti/cpsw*
>  F:	drivers/net/ethernet/ti/davinci*
>  
> +TI FDC1004 DRIVER
> +M:	Victor Chernyakin <chernyakin.victor.j@xxxxxxxxxxx>
> +S:	Maintained
> +F:	Documentation/devicetree/bindings/iio/cdc/ti,fdc1004.yaml
> +
>  TI FLASH MEDIA MEMORYSTICK/MMC DRIVERS
>  M:	Alex Dubov <oakad@xxxxxxxxx>
>  S:	Maintained