Re: [PATCH net v3 2/2] selftests: net: check veth carrier after changing channel counts

From: Hangbin Liu

Date: Thu Oct 22 2026 - 23:15:45 EST


On Fri, Oct 23, 2026 at 10:33:50AM +0800, Xia Yan wrote:
> Hi Hangbin,
>
> Thanks for reproducing the issue and reviewing the driver fix.
>
> > Why do you do gro setting in rx/tx set ups?
>
> I included GRO off/on to cover both queue reconfiguration paths.
> No XDP program is attached in these cases. With GRO on,
> veth_enable_range_safe() and veth_disable_range_safe() set up or tear
> down per-RX-queue NAPI instances as the RX queue count changes. With
> GRO off, those helpers do not need to reconfigure NAPI.
>
> The carrier bug reproduces in both configurations, so the test checks
> the same carrier state with and without the NAPI resource changes.

I mean this doesn't seem related to the carrier on/off (LOWER_UP) issue.
Or did I miss something?

Thanks
Hangbin