Re: [PATCH] tools/bootconfig: Fix enabling all events in bconf2ftrace.sh

[Eduardo Mucelli]

Thanks, Masami!

On Thu, Oct 22, 2026 at 2:52 AM Masami Hiramatsu <mhiramat@xxxxxxxxxx> wrote:
>
> On Wed, 21 Oct 2026 20:16:26 +0200, Eduardo Mucelli Rezende Oliveira <edumucelli@xxxxxxxxx> wrote:
> > A bootconfig containing ftrace.event.enable makes bconf2ftrace.sh try to
> > write to events/enable/enable. The per-event loop treats the global
> > enable key as an event named "enable" in a group with the same name.
> >
> > Since events/enable is a file, this write fails. With --apply, the script
> > exits before it reaches the code that enables all events. The same thing
> > happens with ftrace.instance.NAME.event.enable.
>
> Good catch!
>
> >
> > Skip the global enable key in the per-event loop and let the existing
> > global handler write to events/enable.
>
> This looks good to me. Let me pick it too.
>
> Thanks!
>
> --
> Masami Hiramatsu (Google) <mhiramat@xxxxxxxxxx>
>


-- 
Eduardo Mucelli R. Oliveira -- http://eduar.do