Re: [PATCH] staging: axis-fifo: Fix three real issues
From: Breno Rodrigues Alves
Date: Fri Oct 23 2026 - 04:52:31 EST
Hi Greg,
You are right, and I apologize for the noise. No tool told me this -
it was my own reasoning. I had the (outdated) impression that passing
an ERR_PTR parent from debugfs_create_dir() to debugfs_create_file()
would trigger a WARN in the debugfs core. That was true years ago, but
modern debugfs handles ERR_PTR parents gracefully, and I should have
verified the claim on a CONFIG_DEBUG_FS=n kernel before sending the
patch.
The other two changes are independent of that assumption:
- the -EINVAL -> -ENOBUFS change in axis_fifo_read(), which changes
the errno returned when the user buffer is smaller than the
available data;
- the removal of the unused 'struct resource *r_mem' local.
If either of those is worth keeping, I can resend with just those two.
If the whole patch looks like churn, please let me know and I will drop
it.
Sorry again,
Breno