Re: [PATCH v1 1/1] iio: light: opt4001: Re-use generic struct s32_fract
From: Andy Shevchenko
Date: Fri Oct 23 2026 - 05:21:55 EST
On Fri, Oct 23, 2026 at 11:08:02AM +0200, Andy Shevchenko wrote:
> Instead of custom data type re-use generic struct s32_fract.
> No functional changes intended.
...
> static const struct opt4001_chip_info opt4001_sot_5x3_info = {
> - .mul = 4375,
> - .div = 10000000,
> + ,ratio = { .numerator = 4375, .denominator = 10000000 },
Oh, I should have compiled it, but I missed. Should start with a period, of
course.
> .name = "opt4001-sot-5x3"
> };
> static const struct opt4001_chip_info opt4001_picostar_info = {
> - .mul = 3125,
> - .div = 10000000,
> + ,ratio = { .numerator = 3125, .denominator = 10000000 },
> .name = "opt4001-picostar"
> };
Ditto.
...
Jesper, please take this patch into your series, but also fix those typos.
Or if you are busy, I can do it after my lunch.
--
With Best Regards,
Andy Shevchenko