Re: [PATCH v2] staging: axis-fifo: remove unused r_mem local variable
From: Dan Carpenter
Date: Fri Oct 23 2026 - 06:47:19 EST
On Fri, Oct 23, 2026 at 07:39:43AM -0300, Breno Rodrigues Alves wrote:
> Remove 'struct resource *r_mem' from axis_fifo_probe(). It is filled
> in by devm_platform_get_and_ioremap_resource() but never read; pass
> NULL instead.
>
> This is v2 of a three-change series. The debugfs_create_dir() check
> was dropped because debugfs has handled ERR_PTR parents gracefully
> since 2019 (thanks Greg and Dan for the correction). The
> -EINVAL -> -ENOBUFS change was dropped as well, after Dan Carpenter
> noted that -EINVAL is the common errno for this path and that he
> would leave the choice to the author.
This kind of meta commentary goes below the --- cut off line
>
> Signed-off-by: Breno Rodrigues Alves <breno3011alves@xxxxxxxxx>
> ---
^^^
here.
https://staticthinking.wordpress.com/2022/07/27/how-to-send-a-v2-patch/
As always wait until tomorrow to send v3.
regards,
dan carpenter