Re: [PATCH v4] arm64: dts: qcom: x1e78100-thinkpad-t14s: Add thermal zones for PMICs

[Daniel Lezcano]

On 10/23/26 12:47, Konrad Dybcio wrote:
> On 10/23/26 11:17 AM, Stephan Gerhold wrote:
> > On Fri, Oct 23, 2026 at 10:38:27AM +0200, Daniel Lezcano wrote:
> > > The ThinkPad T14s needs thermal mitigation under sustained workloads to
> > > limit temperature rise before thermal shutdown. EC interrupt-driven thermal
> > > monitoring is not yet supported, so use the board temperature sensors
> > > exposed through the PMK8550 VADC to provide mitigation now.
>
> [...]
>
> > > +		/* Sensor near the CPU PMICs. */
> > > +		cpu-pmic-thermal {
> >
> > I'm a bit confused by the node order here. It's not ordered by the
> > thermal sensor (SYS_THERMx) like in x1e80100-crd.dts, but it's not
> > ordered alphabetically either. Or is it still the old order from the
> > previous revision?
> >
> > I think I'd personally prefer ordering by SYS_THERMx, but alphabetical
> > order would be our typical rule.
>
> Thermistor index is what I'd prefer to go by, I think it makes the
> mostsense

why ?

> Reviewed-by: Konrad Dybcio <konrad.dybcio@xxxxxxxxxxxxxxxx>
>
> thanks!
>
> Konrad