Re: [PATCH] ALSA: sh: aica: Fix spu_memset() stride

From: Takashi Iwai

Date: Fri Oct 23 2026 - 09:45:04 EST


On Thu, 22 Oct 2026 18:32:41 +0200,
Florian Fuchs wrote:
>
> spu_memset() writes one 32-bit word per iteration, but advances the
> destination offset by only one byte. spu_reset() calls it with
> 0x200000 / 4 words to clear the 2 MiB of sound RAM, so:
>
> - three out of four writel() calls target an unaligned address. The
> SH4 can't do that. Each one traps and is emulated by the unaligned
> access fixup. This call to spu_memset() causes 393216 unaligned
> accesses, visible in /proc/cpu/alignment.
> - the clear covered only about 512 KiB of sound RAM, not 2 MiB.
>
> Advance the offset by the size of the written word, to clear the full
> sound RAM using aligned writes.
>
> Fixes: 198de43d758c ("[ALSA] Add ALSA support for the SEGA Dreamcast PCM device")
> Signed-off-by: Florian Fuchs <fuchsfl@xxxxxxxxx>

Applied now. Thanks.


Takashi